Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix id allocator base for double auto_increment field (#1178) #1186

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1178

What problem does this PR solve?

Fix the bug that lightning will got invalid auto_increment base if the corresponding auto_increment field is double/float.

[2021/06/05 13:37:03.227 +08:00] [INFO] [tidb.go:355] ["alter table auto_increment start"] [table=`db`.`table`] [auto_increment=4753151844738400257]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

  • Fix the bug that lightning rebase wrong auto_increment base when the auto_increment field type is float or double.

@3pointer 3pointer force-pushed the cherry-pick-1178-to-release-5.0 branch from 2fc9121 to d2c948b Compare June 17, 2021 03:21
@3pointer
Copy link
Collaborator

/run-integration-tests

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 17, 2021
@3pointer
Copy link
Collaborator

/run-all-tests

1 similar comment
@3pointer
Copy link
Collaborator

/run-all-tests

@3pointer
Copy link
Collaborator

/run-integration-tests

1 similar comment
@3pointer
Copy link
Collaborator

/run-integration-tests

@lonng
Copy link
Contributor

lonng commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: d2c948b

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/run-all-tests

@3pointer
Copy link
Collaborator

/run-integration-tests

@kennytm
Copy link
Collaborator

kennytm commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f8e79d0

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0bb5b37

@glorv glorv force-pushed the cherry-pick-1178-to-release-5.0 branch from 0bb5b37 to 5e6c35e Compare June 25, 2021 06:32
@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5e6c35e

@ti-chi-bot ti-chi-bot merged commit 7eaf375 into pingcap:release-5.0 Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants