Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix split larget csv EOF error (#1134) #1190

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1134

What problem does this PR solve?

close #1133

What is changed and how it works?

don't return io.EOF error if split large csv meets EOF error.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix the bug that lightning returns EOF error when CSV file without '\r\n' at the last line and strict-format = true.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 10, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lonng
Copy link
Contributor

lonng commented Jun 10, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 03385a1

@glorv
Copy link
Collaborator

glorv commented Jun 10, 2021

/build

@ti-chi-bot ti-chi-bot merged commit d5b46bb into pingcap:release-5.1 Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants