Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: prettify data check error output #1331

Merged
merged 8 commits into from
Jul 30, 2021
Merged

lightning: prettify data check error output #1331

merged 8 commits into from
Jul 30, 2021

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Jul 9, 2021 •
edited
Loading

What problem does this PR solve?

Prettify error output for case #1322 and fix a few minor bugs by the way.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

No release note.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from 3pointer and glorv July 9, 2021 09:23
@sleepymole sleepymole requested a review from kennytm July 9, 2021 09:23
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jul 23, 2021
@sleepymole sleepymole requested a review from glorv July 23, 2021 09:16
@sleepymole
Copy link
Contributor Author

/run-all-tests

kennytm
kennytm approved these changes Jul 30, 2021
View reviewed changes
pkg/lightning/restore/check_info.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 30, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jul 30, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8fa7b70

@ti-chi-bot ti-chi-bot merged commit 4f89fa3 into pingcap:master Jul 30, 2021
@sleepymole sleepymole mentioned this pull request Apr 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

@glorv glorv glorv approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
size/L status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleepymole @ti-chi-bot @kennytm @glorv