Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: avoid directly return error if send check multi ingest request failed #1334

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Jul 12, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Little-Wallace
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@glorv
Copy link
Collaborator Author

glorv commented Jul 12, 2021

/run-all-tests

Copy link
Collaborator

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Sep 13, 2021
@kennytm
Copy link
Collaborator

kennytm commented Sep 13, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0156d94

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1434.

ti-chi-bot added a commit that referenced this pull request Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.1.0 - lighting - gRPC i/o timeout
4 participants