Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

restore: add rater for creating tables #1380

Merged
merged 12 commits into from
Aug 4, 2021

Conversation

YuJuncen
Copy link
Collaborator

What problem does this PR solve?

Added a metric in log for collecting create table speed.

What is changed and how it works?

A new type TrivialRater was added, it records the time it was created and how many operations finished after that.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

截屏2021-07-26 上午11 22 10

Side effects

  • Possible performance regression

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

pkg/logutil/rate.go Outdated Show resolved Hide resolved
pkg/logutil/rate.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jul 27, 2021
pkg/logutil/rate.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/logutil/rate.go Outdated Show resolved Hide resolved
Co-authored-by: kennytm <kennytm@gmail.com>
@YuJuncen YuJuncen requested a review from 3pointer August 3, 2021 06:51
@ti-chi-bot ti-chi-bot removed the status/LGT1 LGTM1 label Aug 4, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 LGTM2 label Aug 4, 2021
@YuJuncen
Copy link
Collaborator Author

YuJuncen commented Aug 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 103d241

@ti-chi-bot
Copy link
Member

@YuJuncen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fa9e520 into pingcap:master Aug 4, 2021
@YuJuncen YuJuncen deleted the create-table-rate branch August 4, 2021 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants