Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

restore: create table via meta API #1390

Closed
wants to merge 22 commits into from
Closed

Conversation

YuJuncen
Copy link
Collaborator

@YuJuncen YuJuncen commented Jul 27, 2021

What problem does this PR solve?

Exploring for solution of #1381

What is changed and how it works?

Use meta API to create tables. (an internal design document here) This PR is only for trigger integration tests. DNM.

  • Skip key rewrite.
  • Test over more scenarios.
  • Make change to executor.TiDBGlueSession also

Release note

  • No release notes.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from glorv and ZipFast July 27, 2021 09:48
@YuJuncen YuJuncen marked this pull request as draft July 27, 2021 09:48
@YuJuncen YuJuncen removed request for glorv and ZipFast July 27, 2021 09:48
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Jul 28, 2021
@ti-chi-bot ti-chi-bot added size/L and removed size/XL labels Jul 28, 2021
@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Jul 28, 2021
@YuJuncen
Copy link
Collaborator Author

🤔 Data loss when creating tables with old table ID?

[ERROR] [client.go:805] ["failed in validate checksum"] [db=test] [table=usertable] ["origin tidb crc64"=1740702482933108818] ["calculated crc64"=101439644119139139] ["origin tidb total kvs"=2000] ["calculated total kvs"=2000] ["origin tidb total bytes"=1136000] ["calculated total bytes"=1136000]

@YuJuncen
Copy link
Collaborator Author

/build
🤔

@ti-chi-bot
Copy link
Member

@YuJuncen: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YuJuncen YuJuncen closed this Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants