This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
testing: fix some race conditions in test #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
3pointer
approved these changes
Jul 30, 2021
YuJuncen
requested review from
glorv
and removed request for
overvenus and
lichunzhu
kennytm
approved these changes
Jul 30, 2021
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e735609
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix some test case fails when running with
--race.What is changed and how it works?
Retrieve some locks when executing some tasks, don't use sharing variables, and disabled a non trivial case (see the comment).
Check List
Tests
Side effects
lightning_testwould be disabled when race enabled.Release note