Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: better estimate of the max-open-files #1414

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Aug 5, 2021

What problem does this PR solve?

Make better estimate of the max-open-files by also take import routines into account.

Close #1289

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@glorv glorv requested review from 3pointer and Little-Wallace and removed request for overvenus August 5, 2021 09:16
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 26, 2021
@kennytm
Copy link
Collaborator

kennytm commented Aug 30, 2021

merged into pingcap/tidb#27597 already.

@glorv
Copy link
Collaborator Author

glorv commented Aug 31, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8afaceb

@glorv
Copy link
Collaborator Author

glorv commented Aug 31, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 92fc8b0 into pingcap:master Aug 31, 2021
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Aug 31, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1425.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1426.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Aug 31, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1427.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Too many open files error” when import 2.5TB data using lightning
5 participants