Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

lightning: fix the bug that calculate unfinished ranges may miss some range (#1413) #1416

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1413

What problem does this PR solve?

Fix the bug that lightning local backend may encounter data loss.

Close #1403

What is changed and how it works?

  • Avoid change the global ranges when calculate unfinished ranges
  • Allow writeAndIngestByRanges to fail fast to avoid waiting some much time when met unrecoverable failure.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Use old and new cold to run with a test dataset about 10GB with 50GB disk capacity for sort-kv-dir. Before data loss always occur, and disappeared after this change.
  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Fix the bug that lightning local backend may met checksum mismatch error due to data loss.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 6, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Aug 6, 2021
@IANTHEREAL IANTHEREAL added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 7, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 LGTM1 and removed status/LGT2 LGTM2 labels Aug 7, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 11, 2021
@kennytm
Copy link
Collaborator

kennytm commented Aug 12, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e165999

@ti-chi-bot ti-chi-bot merged commit adff4c1 into pingcap:release-5.1 Sep 13, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.1.2 milestone Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants