Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

br: Remove statement from closure to prevent concurrent operation during backup system table #1450

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1449

What problem does this PR solve?

Issue Number: close pingcap/tidb#29710

Cherry-pick from pingcap/tidb#29730

What is changed and how it works?

Release note

  • No release note

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 8, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

pkg/backup/schema_test.go Outdated Show resolved Hide resolved
@kennytm
Copy link
Collaborator

kennytm commented Dec 13, 2021

@glorv

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:20:2: imported and not used: "github.com/pingcap/br/pkg/storage"

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:194:10: s.GetRandomStorage undefined (type *testBackupSchemaSuite has no field or method GetRandomStorage)

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:213:17: undefined: metautil

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:214:6: assignment mismatch: 1 variable but backupSchemas.BackupSchemas returns 2 values

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:214:35: too many arguments in call to backupSchemas.BackupSchemas

[2021-12-08T02:21:35.969Z] pkg/backup/schema_test.go:218:15: s.GetSchemasFromMeta undefined (type *testBackupSchemaSuite has no field or method GetSchemasFromMeta)

@glorv
Copy link
Collaborator

glorv commented Dec 13, 2021

@joccau PTAL

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Dec 20, 2021
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Dec 20, 2021
@joccau joccau changed the title br: Remove statement from closure to prevent concurrent operation during backup system table (#1449) br: Remove statement from closure to prevent concurrent operation during backup system table Dec 20, 2021
@kennytm
Copy link
Collaborator

kennytm commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 41c75d2

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

Merge canceled because a new commit is pushed.

@joccau
Copy link
Member

joccau commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@joccau: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@joccau joccau closed this Dec 20, 2021
@joccau
Copy link
Member

joccau commented Dec 20, 2021

No need merge, because this concurrent operation bug doesn't exist in version v5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants