Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Spelling error in code comment #569

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Spelling error in code comment #569

merged 4 commits into from
Oct 28, 2020

Conversation

tongtongyin
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

3pointer
3pointer reviewed Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks~

@kennytm kennytm added the status/LGT1 LGTM1 label Oct 26, 2020
@kennytm
Copy link
Collaborator

kennytm commented Oct 26, 2020 •
edited
Loading

Hi @tongtongyin you need to sign the CLA for us to merge this PR. As described in #569 (comment) above, you either need to add the email address lvtuyintongtong<at>gmail.com to your GitHub account, or amend all 3 commits' author to the primary GitHub email address (37565148+tongtongyin@users.noreply.github.com).

@tongtongyin
Copy link
Contributor Author

I have signed License, But it shows no sign, I guess something went wrong elsewhere.

overvenus
overvenus approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@overvenus
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

@overvenus Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1

@overvenus
Copy link
Member

/run-all-tests

@overvenus overvenus added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Oct 28, 2020
@overvenus
Copy link
Member

/build

@overvenus overvenus merged commit 98c94ed into pingcap:master Oct 28, 2020
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Jan 26, 2021
@tongtongyin @ti-srebot
cherry pick pingcap#569 to release-4.0
7bf653b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 26, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #721

3pointer added a commit that referenced this pull request Jan 27, 2021
@ti-srebot @tongtongyin
@3pointer @glorv
cherry pick #569 to release-4.0 (#721)
a878168 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: lvtu <37565148+tongtongyin@users.noreply.github.com>
Co-authored-by: 3pointer <luancheng@pingcap.com>
Co-authored-by: glorv <glorvs@163.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@3pointer 3pointer 3pointer left review comments

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
first-time-contributor needs-cherry-pick-release-4.0 status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tongtongyin @CLAassistant @kennytm @overvenus @ti-srebot @3pointer