Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

test: remove the -d parameter since pd-ctl doesn't support it anymore #681

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Jan 7, 2021

What problem does this PR solve?

Fix integration test error by pd-ctl does not support -d parameter anymore.

This error may be cause by tikv/pd#3337, but seems pd-ctl does not support -d for a long time. (don't know why, but -d seems to always have no effect)

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Release Note

  • No Release Note

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jan 7, 2021
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Jan 7, 2021
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Jan 7, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jan 7, 2021

/lgtm-

CI is stuck at "add shuffle-leader-scheduler".

@glorv
Copy link
Collaborator Author

glorv commented Jan 7, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 697e139 into pingcap:master Jan 7, 2021
@glorv glorv deleted the fix-test branch March 28, 2021 02:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants