Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

*: refine logs #723

Merged
merged 8 commits into from
Jan 28, 2021
Merged

*: refine logs #723

merged 8 commits into from
Jan 28, 2021

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Jan 27, 2021 •
edited
Loading

What problem does this PR solve?

*: restore: more log for split region

It helps investigating #709.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note

@overvenus
*: unify start and end key in log
be0453d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
restore: more log for split regoin
15b0aea 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
*: move redact to its own package and redact Range
52095ac 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
*: unify zap peer and zap ranges
4fd9e3d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
address lints
0f9c510 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
add tests
78ac941 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added this to the v4.0.11 milestone Jan 27, 2021
kennytm
kennytm reviewed Jan 27, 2021
View reviewed changes
pkg/logutil/logging.go Outdated Show resolved Hide resolved
pkg/logutil/logging_test.go Outdated Show resolved Hide resolved
pkg/logutil/logging.go Outdated Show resolved Hide resolved
pkg/rtree/logging.go Outdated Show resolved Hide resolved
pkg/rtree/logging.go Outdated Show resolved Hide resolved
@overvenus
address comments
0787982 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

PTAL

kennytm
kennytm reviewed Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jan 28, 2021
lichunzhu
lichunzhu approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Jan 28, 2021
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Jan 28, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

1 similar comment
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
Copy link
Member Author

/build

@overvenus overvenus merged commit c206add into pingcap:master Jan 28, 2021
ti-srebot pushed a commit to ti-srebot/br that referenced this pull request Jan 28, 2021
@overvenus @ti-srebot
cherry pick pingcap#723 to release-4.0
bb1e732 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 28, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #727

ti-srebot added a commit that referenced this pull request Jan 29, 2021
@ti-srebot
*: refine logs (#723) (#727)
f8b930f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
component/backup component/restore needs-cherry-pick-release-4.0 status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
v4.0.11
Development

Successfully merging this pull request may close these issues.
5 participants
@overvenus @lichunzhu @ti-srebot @kennytm @3pointer