Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding vector index to the Database Model #67

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Support adding vector index to the Database Model #67

merged 6 commits into from
Nov 5, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Oct 23, 2024 •
edited
Loading

What's changed

  • Introduce class VectorIndex and overwrite the create_sql for building the SQL of CREATE VECTOR INDEX ... ON ...
  • Support using L1Distance/L2Distance/CosineDistance/NegativeInnerProduct as expression index
  • Bump the version from 5.0.0 to 5.0.1, so that other libraries can update their requirements version to get the vector index definition

@JaySon-Huang
Support building vector index
889a686 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@sre-bot
Copy link

sre-bot commented Oct 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JaySon-Huang JaySon-Huang mentioned this pull request Oct 23, 2024
Merged
@wd0517
Copy link
Collaborator

wd0517 commented Nov 5, 2024

Good Job!

Please also add some tests for vector index in this file https://github.com/pingcap/django-tidb/blob/main/tests/tidb_vector/test_vector.py

JaySon-Huang and others added 3 commits November 5, 2024 14:51
@JaySon-Huang
Update README
a3c3be0 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@wd0517 @JaySon-Huang
update tidb image of vector ci
00367db
@JaySon-Huang
Add test cases for index
7a7ce68 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Polish the doc
964c0df 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Bump the version to 5.0.1
9b789ae 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 5, 2024 •
edited
Loading

I've added some test case and polish the document.
And also bump the version to 5.0.1 so that other libraries (for example, tidb-vector-python) can update their requirements version to get the vector index definition with "django-tidb==5.0.1"

@wd0517 PTAL again

@wd0517 wd0517 merged commit 9e7027c into pingcap:main Nov 5, 2024
11 checks passed
@JaySon-Huang JaySon-Huang deleted the support_vector_index branch November 5, 2024 09:46
@wd0517
Copy link
Collaborator

wd0517 commented Nov 5, 2024

I'll cherry-pick this feature to stable/4.2.x and stable/4.1.x branch later.

wd0517 pushed a commit that referenced this pull request Nov 14, 2024
@JaySon-Huang @wd0517
Support adding vector index to the Database Model (#67)
b77ea88
wd0517 pushed a commit that referenced this pull request Nov 14, 2024
@JaySon-Huang @wd0517
Support adding vector index to the Database Model (#67)
01fdc0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd0517 wd0517 wd0517 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @sre-bot @wd0517