sycner: automatically use upstream sql_mode (#1306)

pingcap · Nov 26, 2020 · e51b4fe · e51b4fe
1 parent b975729
commit e51b4fe
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/syncer/syncer.go b/syncer/syncer.go
@@ -264,7 +264,7 @@ func (s *Syncer) Init(ctx context.Context) (err error) {
 		return err
 	}
 
-	err = s.createDBs()
+	err = s.createDBs(ctx)
 	if err != nil {
 		return err
 	}
@@ -2342,7 +2342,7 @@ func (s *Syncer) printStatus(ctx context.Context) {
 	}
 }
 
-func (s *Syncer) createDBs() error {
+func (s *Syncer) createDBs(ctx context.Context) error {
 	var err error
 	dbCfg := s.cfg.From
 	dbCfg.RawDBCfg = config.DefaultRawDBConfig().SetReadTimeout(maxDMLConnectionTimeout)
@@ -2351,6 +2351,27 @@ func (s *Syncer) createDBs() error {
 		return err
 	}
 
+	hasSQLMode := false
+	// get sql_mode from upstream db
+	if s.cfg.To.Session == nil {
+		s.cfg.To.Session = make(map[string]string)
+	} else {
+		for k := range s.cfg.To.Session {
+			if strings.ToLower(k) == "sql_mode" {
+				hasSQLMode = true
+				break
+			}
+		}
+	}
+	if !hasSQLMode {
+		sqlMode, err2 := utils.GetGlobalVariable(ctx, s.fromDB.BaseDB.DB, "sql_mode")
+		if err2 != nil {
+			s.tctx.L().Warn("cannot get sql_mode from upstream database", log.ShortError(err2))
+		} else {
+			s.cfg.To.Session["sql_mode"] = sqlMode
+		}
+	}
+
 	dbCfg = s.cfg.To
 	dbCfg.RawDBCfg = config.DefaultRawDBConfig().
 		SetReadTimeout(maxDMLConnectionTimeout).

diff --git a/tests/all_mode/data/db2.increment.sql b/tests/all_mode/data/db2.increment.sql
@@ -1,2 +1,6 @@
 use all_mode;
 delete from t2 where name = 'Sansa';
+
+
+-- test sql_mode=NO_AUTO_VALUE_ON_ZERO
+insert into t2 (id, name) values (0,'haha')