Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

UCP: remove remove-meta config for task #496

Closed
WangXiangUSTC opened this issue Feb 28, 2020 · 1 comment
Closed

UCP: remove remove-meta config for task #496

WangXiangUSTC opened this issue Feb 28, 2020 · 1 comment

Comments

@WangXiangUSTC
Copy link
Contributor

WangXiangUSTC commented Feb 28, 2020

Description

Is your feature request related to a problem? Please describe:

If set remove-meta: true in task's config file, it will always delete the meta information in the checkpoint table when starting/recovering the task. It is easy to misuse and delete the checkpoint, then the task will run as a new task.

Describe the feature you'd like:

  • remove remove-meta config for task
  • add another argument (like --remove-meta) for the start-task command
  • or add a new command for dmctl to remove the meta information in checkpoint table, just like:
dmctl --master-addr "127.0.0.1:8261" --task-name test --remove-meta

Score

600

Mentor(s)

Contact the mentors: #tidb-challenge-program channel in TiDB Community Slack Workspace

Recommended Skills

  • Golang
  • Experience with DM

Learning Materials

@WangXiangUSTC WangXiangUSTC added the type/feature-request This issue is a feature request label Feb 28, 2020
@WangXiangUSTC WangXiangUSTC changed the title remove remove-meta config for task UCP: remove remove-meta config for task Feb 28, 2020
@csuzhangxc
Copy link
Member

this has been done in #651.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants