This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dm-ha/: add remove metadata feature #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
priority/normal
lichunzhu
changed the title
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
===========================================
Coverage 57.0840% 57.0840%
===========================================
Files 204 204
Lines 20899 20899
===========================================
Hits 11930 11930
Misses 7818 7818
Partials 1151 1151 |
lichunzhu
added
status/PTAL
|
/run-all-tests |
csuzhangxc
reviewed
May 8, 2020
csuzhangxc
reviewed
May 8, 2020
csuzhangxc
reviewed
May 12, 2020
| sources = append(sources, stCfg.SourceID) | ||
| } | ||
| if req.RemoveMeta { | ||
| if scm := s.scheduler.GetSubTaskCfgsByTask(cfg.Name); len(scm) > 0 { |
There was a problem hiding this comment.
Do we need any mechanism to prevent start-task in another client when removing meta?
There was a problem hiding this comment.
Add removeMetaLock
There was a problem hiding this comment.
why need a lock, may start task with same task name?
There was a problem hiding this comment.
em... may user start-task again when the previous start-task is still removing meta?
csuzhangxc
added
status/LGT1
|
/run-all-tests |
|
@lichunzhu need to resolve conflicts |
will resolve conflicts after #654 is merged at one time |
|
@WangXiangUSTC Already resolved. |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
WangXiangUSTC
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#567
support
remove-metafor dm-haWhat is changed and how it works?
remove-metain dm-worker.Check List
Tests
Code changes
Related changes