This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
test: bring run-compatibility-test
back (#1128)
#1135
Merged
lance6716
merged 3 commits into
pingcap:release-2.0
from
ti-srebot:release-2.0-ee7d5980ac99
Oct 12, 2020
Merged
test: bring run-compatibility-test
back (#1128)
#1135
lance6716
merged 3 commits into
pingcap:release-2.0
from
ti-srebot:release-2.0-ee7d5980ac99
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
first-time-contributor
priority/normal
Minor change, requires approval from ≥1 primary reviewer
type/cherry-pick
This PR is just a cherry-pick (backport)
type/test
Changes related to test cases
labels
Oct 10, 2020
not sure 2.0 will need this, I suppose only develop branch need check compatibility |
we may open PR to release-2.0 branch someday if we are developing v3.0 on the master branch. |
GMHDBJD
reviewed
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Oct 12, 2020
/run-all-tests |
/run-compatibility-test |
/run-all-tests |
1 similar comment
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
first-time-contributor
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/cherry-pick
This PR is just a cherry-pick (backport)
type/test
Changes related to test cases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1128 to release-2.0
What problem does this PR solve?
reveal bug that break upgrading.
What is changed and how it works?
compatibility test will run a 1-master-2-worker task, try kill-and-replace master, worker, another worker to check task running well.
default behaviour:
v2.0.0-rc
compatibility
apart from #262, use
/run-compatibility-test break_compatibility=true
to bypass compatibility test if PR require break compatibilityCheck List
Tests
Code changes
Side effects
Related changes