Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: bring run-compatibility-test back (#1128) #1135

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1128 to release-2.0


What problem does this PR solve?

reveal bug that break upgrading.

What is changed and how it works?

compatibility test will run a 1-master-2-worker task, try kill-and-replace master, worker, another worker to check task running well.

default behaviour:

  • old master and worker are v2.0.0-rc
  • only run compatibility

apart from #262, use /run-compatibility-test break_compatibility=true to bypass compatibility test if PR require break compatibility

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) type/test Changes related to test cases labels Oct 10, 2020
@lance6716
Copy link
Collaborator

not sure 2.0 will need this, I suppose only develop branch need check compatibility

@csuzhangxc
Copy link
Member

not sure 2.0 will need this, I suppose only develop branch need check compatibility

we may open PR to release-2.0 branch someday if we are developing v3.0 on the master branch.

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Oct 12, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 12, 2020
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-compatibility-test

@lance6716
Copy link
Collaborator

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716 lance6716 merged commit 41cbe7f into pingcap:release-2.0 Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/test Changes related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants