This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dumpling: properly enable EscapeBackslash with upstream SQL mode #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
lance6716
changed the title
csuzhangxc
reviewed
Oct 12, 2020
| @@ -277,4 +276,9 @@ func (m *Dumpling) detectSQLMode() { | |||
| } | |||
| m.logger.Info("found upstream SQL mode", zap.String("SQL mode", sqlMode)) | |||
| m.cfg.LoaderConfig.SQLMode = sqlMode | |||
| if strings.Contains(sqlMode, "NO_BACKSLASH_ESCAPES") { | |||
There was a problem hiding this comment.
we may also use HasNoBackslashEscapesMode from TiDB instead.
There was a problem hiding this comment.
If it's Aurora upstream, some SQL mode can't be supported using TiDB parser
csuzhangxc
added
status/LGT1
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Oct 13, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1151 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Oct 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #1130
What is changed and how it works?
because loader will use upstream's SQL mode, if upstream has
NO_BACKSLASH_ESCAPES, we should not escape\in dump files.Check List
Tests
Code changes
Side effects
Related changes