Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

election: don't forwarding when startLeaderComponent (#1118) #1157

Merged
merged 2 commits into from
Oct 14, 2020
Merged

election: don't forwarding when startLeaderComponent (#1118) #1157

merged 2 commits into from
Oct 14, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1118 to release-2.0

What problem does this PR solve?

close #1088

What is changed and how it works?

lock more code

Check List

Tests

  • Pass original test

Code changes

Side effects

  • Possible performance regression

Related changes

  • Need to cherry-pick to the release branch

@lance6716 @ti-srebot
cherry pick pingcap#1118 to release-2.0
b3a5887 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 13, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) first-time-contributor labels Oct 13, 2020
GMHDBJD
GMHDBJD reviewed Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added the status/LGT1 One reviewer already commented LGTM label Oct 14, 2020
csuzhangxc
csuzhangxc approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 666a89b into pingcap:release-2.0 Oct 14, 2020
@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 14, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@WangXiangUSTC WangXiangUSTC Awaiting requested review from WangXiangUSTC

Assignees
No one assigned
Labels
first-time-contributor priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @csuzhangxc @GMHDBJD @lance6716