This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
syncer/checkpoint: ignore cancel for update/delete (#1174) #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
priority/important
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1174 to release-2.0
What problem does this PR solve?
close #1172
What is changed and how it works?
for lease change, when update/delete checkpoint in DB, use a new context with 5-minute timeout, to avoid syncer's
cancel()did not let SQL commit.create checkpoint is only called at syncer's
Init, seems OK to be canceledread checkpoint doesn't have a side effect, OK to be canceled
those methods are called from
Run -> handleQueryEvent, which may block when pause/stop. Maybe we need #605Check List
Tests
Code changes
Side effects
Related changes