Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

Add unsafe_cleanup.yml for dm ansible #128

Merged
merged 1 commit into from
Apr 28, 2019
Merged

Add unsafe_cleanup.yml for dm ansible #128

merged 1 commit into from
Apr 28, 2019

Conversation

wilanhuang
Copy link
Contributor

What problem does this PR solve? 

Users can unsafe_cleanup the dm module using the new adding yml file in ansible

What is changed and how it works?

 Add a file named unsafe_cleanup.yml in ansible

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    ansible-playbook unsafe_cleanup.yml

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@amyangfei
Copy link
Contributor

/run-all-tests

@IANTHEREAL
Copy link
Collaborator

Cool! Thanks @wilanhuang

liubo0127
liubo0127 approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@liubo0127 liubo0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csuzhangxc
csuzhangxc reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature labels Apr 26, 2019
@csuzhangxc
Copy link
Member

@wilanhuang Thanks! Please sign the CLA.

@csuzhangxc
Copy link
Member

CLA bot seems to have any problem, I'm going to merge the PR ignoring the CLA status

@csuzhangxc csuzhangxc merged commit 7fb5ca5 into pingcap:master Apr 28, 2019
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@wilanhuang @csuzhangxc
Add unsafe_cleanup.yml for dm ansible (pingcap#128)
5508d97
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@liubo0127 liubo0127 liubo0127 approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wilanhuang @CLAassistant @amyangfei @IANTHEREAL @csuzhangxc @liubo0127 @wilanhuangwebank