This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: refine context usage to avoid potential blocks (#1285) #1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1285 to release-2.0
What problem does this PR solve?
refine context usage to avoid potential blocks, like:
fix #1279
What is changed and how it works?
add context for DB operations.
some suggestions for later dev:
QueryContext
/ExecContext
rather thanQuery
/Exec
for DB operationscontext.Background
for most cases except in testing codecontext.Context
andlogger
into atcontext.Context
may be not a good idea, becasecontext.Context
often takes effect in a single process workflow butlogger
often takes effect in a whole componenttcontext.Context
may still need to be refined laterCheck List
Tests
Code changes
Side effects
Related changes