This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
sycner: automatically use upstream sql_mode (#1306) #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
LGTM |
GMHDBJD
added
status/LGT2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1306 to release-2.0
What problem does this PR solve?
Inconsistent upstream and downstream sql_mode leads to inconsistent data
What is changed and how it works?
get dsn scope sql_mode from upstream database if sql_mode is not specified in task config.
Still can't use different session sql_mode base on different binlog event like mysql master-slave replication. One solution is get sql_mode from
beginevent and apply it for rows event in same txn, which is ineffective.Check List
Tests