This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
bug-fix: fix currentLocation not increase in rows event #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
priority/normal
Minor change, requires approval from ≥1 primary reviewer
type/bug-fix
Bug fix
priority/important
Major change, requires approval from ≥2 primary reviewers
status/PTAL
This PR is ready for review. Add this label back after committing new changes
and removed
priority/normal
Minor change, requires approval from ≥1 primary reviewer
labels
Dec 10, 2020
csuzhangxc
reviewed
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Dec 10, 2020
csuzhangxc
added
the
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
label
Dec 10, 2020
lance6716
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Dec 10, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1330 |
ti-srebot
added
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
labels
Dec 10, 2020
lance6716
added a commit
to lance6716/dm
that referenced
this pull request
Dec 10, 2020
csuzhangxc
pushed a commit
that referenced
this pull request
Dec 11, 2020
overvenus
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test?
lance6716
added a commit
that referenced
this pull request
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
priority/important
Major change, requires approval from ≥2 primary reviewers
status/LGT1
One reviewer already commented LGTM
type/bug-fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
row event's currentLocation not update due to #1303
in #1303, we disable handle-error for rows event, but also skip update currentLocation by mistake.
What is changed and how it works?
update currentlocation in handleRowEvents
Check List
Tests
manually test
add more auto test for transaction later.