Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

feat: add get-config command (#1323) #1348

Merged
merged 2 commits into from
Dec 21, 2020
Merged

feat: add get-config command (#1323) #1348

merged 2 commits into from
Dec 21, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1323 to release-2.0

What problem does this PR solve?

use get-config command to get task/worker/master/source cfg.

What is changed and how it works?

  • refine get-task-config to support merge from subtask
  • get worker/master/source cfg

Check List

Tests

  • Unit test
  • Integration test

@GMHDBJD @ti-srebot
cherry pick pingcap#1323 to release-2.0
38aae74 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Dec 18, 2020
Merged
2 tasks
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 18, 2020
@lance6716
Copy link
Collaborator

@GMHDBJD need resolve conflict

@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Dec 21, 2020

/run-all-tests

1 similar comment
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Dec 21, 2020

/run-all-tests

csuzhangxc
csuzhangxc approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 3754a46 into pingcap:release-2.0 Dec 21, 2020
@csuzhangxc csuzhangxc added the status/LGT1 One reviewer already commented LGTM label Dec 21, 2020
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @GMHDBJD @csuzhangxc