Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: support and sync mutiple endpoints (#1333) #1349

Merged
merged 5 commits into from
Dec 24, 2020

Conversation

ti-srebot
Copy link

cherry-pick #1333 to release-2.0


What problem does this PR solve?

close #1278

What is changed and how it works?

sync etcd enpoints, dial dm-master before send request

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    connect dmctl to master clusters, kill one master, dmctl still can send request to others.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer labels Dec 18, 2020
@ti-srebot ti-srebot added the type/cherry-pick This PR is just a cherry-pick (backport) label Dec 18, 2020
@lance6716
Copy link
Collaborator

new conflicts appeared @GMHDBJD

@csuzhangxc csuzhangxc added this to the v2.0.1 milestone Dec 22, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Dec 24, 2020
@csuzhangxc csuzhangxc merged commit 3dec335 into pingcap:release-2.0 Dec 24, 2020
@lance6716 lance6716 added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants