This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dmctl: use dmctl binary directly in integration test #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
22 tasks
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
Coverage ? 34.267%
==========================================
Files ? 121
Lines ? 13602
Branches ? 0
==========================================
Hits ? 4661
Misses ? 8412
Partials ? 529 |
csuzhangxc
reviewed
May 20, 2019
csuzhangxc
reviewed
May 20, 2019
csuzhangxc
reviewed
May 20, 2019
|
/run-all-tests |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
csuzhangxc
added
status/LGT1
IANTHEREAL
reviewed
May 21, 2019
dm/ctl/common/sql_operation.go
Outdated
| // return binlog-pos, sql-pattern, sharding, error | ||
| func extractBinlogPosSQLPattern(cmd *cobra.Command) (string, string, bool, error) { | ||
| func ExtractBinlogPosSQLPattern(cmd *cobra.Command) (string, string, bool, error) { |
There was a problem hiding this comment.
should we still put this function into dm/master, it seems we wouldn't use it somewhere else, because of cmd argument
There was a problem hiding this comment.
I have the same question, but I did not raise it.:satisfied:
There was a problem hiding this comment.
addressed @GregoryIan PTAL
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
csuzhangxc
approved these changes
May 22, 2019
csuzhangxc
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add integration test for dmctl
DNM until #142 is merged, this pr has same fix code in #142
What is changed and how it works?
dmctl_basictest. Other dmctl related tests will be added later in more PRsCheck List
Tests