Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

loader: fix loader lost data when quickly starts/stops task #1378

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jan 14, 2021

What problem does this PR solve?

close #1377

What is changed and how it works?

cleanDumpfiles only finish task

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added type/bug-fix Bug fix needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 14, 2021
@GMHDBJD GMHDBJD changed the title loader: fix loader lost data when frequently starts/stops task loader: fix loader lost data when quickly starts/stops task Jan 14, 2021
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Collaborator

/lgtm

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Jan 18, 2021
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 2ecaa73 into pingcap:master Jan 19, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Jan 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1389

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 19, 2021
lance6716 pushed a commit that referenced this pull request Jan 19, 2021
@lance6716 lance6716 added this to the v2.0.2 milestone Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load phase of all mode may lost data when worker frequently starts/stops task
4 participants