Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

util: fix status_vars can't parse more than one 0-terminated string #1382

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

close #1381

What is changed and how it works?

reset a vairable when finish reading one 0-terminated string

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jan 16, 2021
@lance6716 lance6716 added this to the v2.0.2 milestone Jan 16, 2021
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added the status/LGT1 One reviewer already commented LGTM label Jan 18, 2021
@lance6716 lance6716 merged commit dabf6f6 into pingcap:master Jan 18, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Jan 18, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1387

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Jan 18, 2021
lance6716 pushed a commit that referenced this pull request Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated status/LGT1 One reviewer already commented LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: fail to parse binglog status_vars
3 participants