This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
relay: align with MySQL when using GTID #1390
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fa9bdec
refine getPosByGTID
GMHDBJD 0cc8fbc
replace with heartbeat event
GMHDBJD 25ee593
add GenHeartbeatEvent
GMHDBJD 7547e3c
update event
GMHDBJD 38e3f64
add ut
GMHDBJD 3018b3f
adjust gtid for relay
GMHDBJD c4126cc
fix mariadb gtid list event
GMHDBJD bf53a53
fix update mariadb gtid
GMHDBJD 554f460
fix fmt
GMHDBJD 726a5b4
add comment
GMHDBJD b460226
Merge branch 'master' into relayGTID
GMHDBJD 91d1adb
address comment
GMHDBJD 6fe54f7
add comment
GMHDBJD 2365e5e
Update pkg/streamer/reader.go
lance6716 4bd7750
Update pkg/streamer/reader.go
lance6716 8a6763b
Merge branch 'master' into relayGTID
lance6716 34b2304
Merge branch 'master' into relayGTID
lichunzhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
source-id: "replica-03" | ||
enable-gtid: false | ||
enable-gtid: true | ||
enable-relay: true | ||
|
||
from: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does MySQL choose not keeping size? I think this may cause positions in
query-status
mismatched which may confuse userThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It keeps the LogPos but not EventSize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That meets problem when we calculate startPosition, but we don't calculate it for heartbeat event.