This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
config: add warning, when users set configuration to mydumper/loader/syncer b… #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
changed the title
lance6716
added
needs-cherry-pick-release-2.0
lichunzhu
reviewed
Jan 29, 2021
good idea |
lance6716
reviewed
Feb 1, 2021
|
for failed tests, you could sort the slice to get the stable result. rest LGTM |
lance6716
reviewed
Feb 2, 2021
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Feb 2, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1415 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Feb 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut not use them
What problem does this PR solve?
For some configurations like routes/filters/mydumpers/loaders/syncers that users set in global configuration, this pr add “reference count” for these configurations.
What is changed and how it works?
When some configurations are set in global configuration, but instances don't use thme. An error will return.
Tests