This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
gtid, relay: use gtid_purged to handle gap in Previous_gtids event
#1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
changed the title
gtid_purged to handle gap in Previous_gtids eventgtid_purged to handle gap in Previous_gtids event
lance6716
added
needs-cherry-pick-release-2.0
lance6716
commented
Feb 5, 2021
lance6716
added
the
status/PTAL
lance6716
changed the title
gtid_purged to handle gap in Previous_gtids eventgtid_purged to handle gap in Previous_gtids event
lichunzhu
reviewed
Feb 19, 2021
| // because it doesn't cover all gtid_purged. The error of using it will be | ||
| // ERROR 1236 (HY000): The slave is connecting using CHANGE MASTER TO MASTER_AUTO_POSITION = 1, but the master has purged binary logs containing GTIDs that the slave requires. | ||
| // so we add gtid_purged to it. | ||
| func AddGSetWithPurged(ctx context.Context, gset gtid.Set, conn *sql.Conn) (gtid.Set, error) { |
There was a problem hiding this comment.
Why do we use sql.Conn instead of sql.DB here?
There was a problem hiding this comment.
some callers only hold sql.Conn not sql.DB
There was a problem hiding this comment.
in line 108 of pkg/v1dbschema/schema.go (below file). I'll close connection in next commit
| if err2 != nil { | ||
| return err2 | ||
| } | ||
| latestGTID, err2 = utils.AddGSetWithPurged(ctx, latestGTID, dbConn) |
There was a problem hiding this comment.
If we don't add purged gtid to result.LatestGTIDs, do we need to add purged gtid to latestGTID here?
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Feb 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1441 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
added a commit
that referenced
this pull request
Feb 19, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: lance6716 <lance6716@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #1418 (we need to test master-slave upstream manually later)
What is changed and how it works?
remove ResetStart, instead, query
@@gtid_purgedand combine it to gtid set when neededCheck List
Tests
Code changes
Side effects
Related changes