Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: refine metrics (#1438) #1443

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Feb 20, 2021

cherry-pick #1438 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1443

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1443:release-2.0-2fa864f33260

What problem does this PR solve?

part of #1218
part of #1419

What is changed and how it works?

  • don't overwrite prometheus registry so metrics of embedded etcd could be exposed
  • add alert when no master is up
  • fix prometheus query error of one-to-many subtraction
  • remove duplicate copys of metrics config files

Check List

Tests

  • Integration test
  • Manual test (check group_right could work)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 20, 2021
@ti-srebot ti-srebot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport) labels Feb 20, 2021
@lance6716 lance6716 merged commit b9f9f5c into pingcap:release-2.0 Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants