This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Mar 11, 2021
lance6716
commented
Mar 11, 2021
} | ||
|
||
// GetRelayConfig returns the source config which the given worker need to pull relay log from etcd, with revision | ||
func GetRelayConfig(cli *clientv3.Client, worker string) (*config.SourceConfig, int64, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost same with
Line 167 in 5141e05
// GetSourceBoundConfig gets the source bound relationship and relative source config at the same time |
lichunzhu
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will one worker be bound with several relay sources?
Rest LGTM
currently not. User may need to deploy more worker if he want to increase relay replica number |
/lgtm |
GMHDBJD
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1505 |
ti-srebot
added
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
and removed
needs-cherry-pick-release-2.0
This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0
labels
Mar 12, 2021
lance6716
pushed a commit
that referenced
this pull request
Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-2.0
The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
status/LGT1
One reviewer already commented LGTM
status/PTAL
This PR is ready for review. Add this label back after committing new changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of support
start-relay
of one source to many workersWhat is changed and how it works?
add etcd key prefix, k/v: worker-name -> source-id
Check List
Tests
Code changes
Side effects
Related changes