Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: query-status -s and purge-relay send to all relay worker #1533

Merged
merged 59 commits into from
Apr 9, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

query-status -s and purge-relay send to all relay worker

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@lance6716
Copy link
Collaborator Author

lance6716 commented Apr 8, 2021

CI failed because master discover offline worker too late https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/dm_ghpr_test/detail/dm_ghpr_test/8756/pipeline/76/ :

(locally test)
worker2: [2021/04/08 10:38:25.886 +08:00] [INFO] [main.go:92] ["dm-worker exit"]
master3 (leader): [2021/04/08 10:39:09.994 +08:00] [INFO] [scheduler.go:1321] ["receive worker status change event"] [component=scheduler] [delete=true] [event="{"worker-name":"worker2","join-time":"0001-01-01T00:00:00Z"}"]

@lance6716
Copy link
Collaborator Author

CI failed:

I don't know why there's only one "Welcome to dm-worker" in worker4.log, but

[2021-04-08T03:22:51.586Z] [2021/04/08 11:22:29.931 +08:00] [INFO] [main.go:84] ["got signal to exit"] [signal=terminated]
[2021-04-08T03:22:51.586Z] [2021/04/08 11:22:30.354 +08:00] [INFO] [main.go:92] ["dm-worker exit"]
[2021-04-08T03:22:51.586Z] [2021/04/08 11:22:30.380 +08:00] [INFO] [main.go:84] ["got signal to exit"] [signal=terminated]

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 8, 2021
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

@GMHDBJD PTAL

Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 9, 2021
@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e08bad

@ti-chi-bot ti-chi-bot merged commit 83f7610 into pingcap:master Apr 9, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Apr 9, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1570

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Apr 9, 2021
lance6716 added a commit to lance6716/dm that referenced this pull request Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants