Skip to content
This repository was archived by the owner on Nov 24, 2023. It is now read-only.

binlog/event: improve parsing MariaDB status vars in binlog #1552

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

lance6716
Copy link
Collaborator

What problem does this PR solve?

a warning in log

What is changed and how it works?

support this new status vars from MariaDB

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot requested review from kennytm and lichunzhu April 2, 2021 06:57
@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Apr 2, 2021
@lance6716 lance6716 added this to the v2.0.2 milestone Apr 2, 2021
@lance6716 lance6716 added the needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated label Apr 2, 2021
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Apr 6, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 6, 2021
@lance6716
Copy link
Collaborator Author

/label require-LGT1

@ti-chi-bot
Copy link
Member

@lance6716: The label(s) require-lgt1 cannot be applied. These labels are supported: Hacktoberfest, TiDB-5.0, already-cherry-pick-1.0, already-cherry-pick-2.0, already-update-dm-ansible, already-update-docs, already-update-release-note, dependencies, good first issue, help wanted, high-performance, hptc, javascript, needs-cherry-pick-1.0, needs-cherry-pick-2.0, needs-update-dm-ansible, needs-update-docs, needs-update-release-note, question, release-track.

In response to this:

/label require-LGT1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lance6716: The label(s) require-lgt1 cannot be applied. These labels are supported: Hacktoberfest, TiDB-5.0, already-cherry-pick-1.0, already-cherry-pick-2.0, already-update-dm-ansible, already-update-docs, already-update-release-note, dependencies, good first issue, help wanted, high-performance, hptc, javascript, needs-cherry-pick-1.0, needs-cherry-pick-2.0, needs-update-dm-ansible, needs-update-docs, needs-update-release-note, question, release-track.

In response to this:

/label require-LGT1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from ti-chi-bot Apr 6, 2021
@ti-chi-bot
Copy link
Member

@lance6716: The label(s) require-lgt1 cannot be applied. These labels are supported: Hacktoberfest, TiDB-5.0, already-cherry-pick-1.0, already-cherry-pick-2.0, already-update-dm-ansible, already-update-docs, already-update-release-note, dependencies, good first issue, help wanted, high-performance, hptc, javascript, needs-cherry-pick-1.0, needs-cherry-pick-2.0, needs-update-dm-ansible, needs-update-docs, needs-update-release-note, question, release-track.

In response to this:

/label require-LGT1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@pingcap pingcap deleted a comment from ti-chi-bot Apr 6, 2021
@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label Apr 6, 2021
@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 521de96

@ti-chi-bot ti-chi-bot merged commit d484b1c into pingcap:master Apr 6, 2021
ti-srebot pushed a commit to ti-srebot/dm that referenced this pull request Apr 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #1563

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Apr 6, 2021
lance6716 pushed a commit that referenced this pull request Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/S status/can-merge status/LGT1 One reviewer already commented LGTM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants