Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

rpc: add rate limit and rpc client manage in dm-master #157

Merged
merged 31 commits into from
Jun 21, 2019
Merged

rpc: add rate limit and rpc client manage in dm-master #157

merged 31 commits into from
Jun 21, 2019

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 24, 2019 •
edited
Loading

What problem does this PR solve?

ref: #131

What is changed and how it works?

  1. add rate limit in rpc request
  2. add a new interface to manage rpc client in dm-master

Check List

Tests

  • Unit test
  • Integration test

@amyangfei amyangfei added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/enhancement Performance improvement or refactoring labels May 24, 2019
@amyangfei amyangfei force-pushed the rpc-process-tuning branch from 321d2e6 to e3e241e Compare May 27, 2019 02:37
@codecov
Copy link

codecov bot commented May 27, 2019 •
edited
Loading

Codecov Report

Merging #157 into master will decrease coverage by 0.0311%.
The diff coverage is 56.3549%.

@@               Coverage Diff                @@
##             master       #157        +/-   ##
================================================
- Coverage   53.2376%   53.2064%   -0.0312%     
================================================
  Files           121        121                
  Lines         13652      13816       +164     
================================================
+ Hits           7268       7351        +83     
- Misses         5655       5719        +64     
- Partials        729        746        +17

@amyangfei amyangfei force-pushed the rpc-process-tuning branch 5 times, most recently from 908a354 to 1b51034 Compare May 27, 2019 15:25
@amyangfei amyangfei force-pushed the rpc-process-tuning branch from 1b51034 to f4d1a3d Compare May 28, 2019 06:18
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei amyangfei force-pushed the rpc-process-tuning branch 2 times, most recently from 9fa429e to c4a668c Compare May 29, 2019 16:08
@amyangfei amyangfei force-pushed the rpc-process-tuning branch from c4a668c to 2baedc5 Compare May 29, 2019 16:19
@amyangfei amyangfei changed the title rpc: add rate limit in rpc from dm-master to dm-worker rpc: add rate limit and rpc client manage in dm-master May 30, 2019
@amyangfei amyangfei force-pushed the rpc-process-tuning branch from e96235d to 25f9b59 Compare May 30, 2019 06:50
@amyangfei amyangfei added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels May 30, 2019
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

PTAL @GregoryIan @csuzhangxc

csuzhangxc
csuzhangxc reviewed Jun 11, 2019
View reviewed changes
dm/master/agent_pool.go Outdated Show resolved Hide resolved
amyangfei and others added 2 commits June 11, 2019 22:23
@amyangfei @csuzhangxc
Update dm/master/agent_pool.go
29c9853 
Co-Authored-By: Xuecheng Zhang <csuzhangxc@gmail.com>
@amyangfei
address comment
e067772
@amyangfei amyangfei force-pushed the rpc-process-tuning branch from c63653f to e067772 Compare June 11, 2019 14:32
@amyangfei
Copy link
Contributor Author

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor Author

PTAL @csuzhangxc

csuzhangxc
csuzhangxc reviewed Jun 19, 2019
View reviewed changes
dm/master/config.go Show resolved Hide resolved
dm/master/config.go Outdated Show resolved Hide resolved
dm/master/dm-master.toml Show resolved Hide resolved
@csuzhangxc
Copy link
Member

@amyangfei CI was broken

@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-all-tests

csuzhangxc
csuzhangxc reviewed Jun 20, 2019
View reviewed changes
dm/master/server.go Show resolved Hide resolved
dm/master/server.go Show resolved Hide resolved
dm/master/server.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/master/server.go Outdated Show resolved Hide resolved
dm/master/server.go Show resolved Hide resolved
dm/master/server_test.go Outdated Show resolved Hide resolved
csuzhangxc
csuzhangxc approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 21, 2019
@amyangfei amyangfei merged commit 82ecc4b into pingcap:master Jun 21, 2019
@amyangfei amyangfei deleted the rpc-process-tuning branch June 21, 2019 08:20
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@amyangfei
rpc: add rate limit and rpc client manage in dm-master (pingcap#157)
a3a96b8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suzaku suzaku suzaku left review comments

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @IANTHEREAL @zhouqiang-cl @csuzhangxc @suzaku