Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

master: support unlock-ddl-lock after stop-task (#1605) #1612

Merged
merged 2 commits into from
Apr 20, 2021
Merged

master: support unlock-ddl-lock after stop-task (#1605) #1612

merged 2 commits into from
Apr 20, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Apr 20, 2021 •
edited
Loading

cherry-pick #1605 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1612

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1612:release-2.0-cefae07304aa

What problem does this PR solve?

close #1543

What is changed and how it works?

skip this check

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 @ti-srebot
cherry pick pingcap#1605 to release-2.0
237ed27 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/M type/cherry-pick This PR is just a cherry-pick (backport) labels Apr 20, 2021
@ti-chi-bot ti-chi-bot requested a review from kennytm April 20, 2021 07:42
GMHDBJD
GMHDBJD approved these changes Apr 20, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 20, 2021
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Apr 20, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a3ec45

@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 0568756 into pingcap:release-2.0 Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/M status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lance6716 @ti-chi-bot @GMHDBJD