Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: show an unsynced message for workers which didn't get any shard DDL (#1638) #1650

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1638

What problem does this PR solve?

some users don't use show-ddl-locks to get unsynced tables, they use query-status instead, so we also show reasonable message in query-status

What is changed and how it works?

Check List

Tests

  • Integration test

Code changes

  • Has (user) interface methods change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L type/cherry-pick-for-release-2.0 labels May 6, 2021
dm/worker/worker_test.go Outdated Show resolved Hide resolved
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 6, 2021
@lance6716 lance6716 added require-LGT1 for small PR, LGT1 is enough and removed status/LGT1 One reviewer already commented LGTM labels May 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 6, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b91004c

@ti-chi-bot ti-chi-bot merged commit 33832b6 into pingcap:release-2.0 May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/L status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants