This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
*: show an unsynced message for workers which didn't get any shard DDL (#1638) #1650
Merged
ti-chi-bot
merged 7 commits into
pingcap:release-2.0
from
ti-chi-bot:cherry-pick-1638-to-release-2.0
May 6, 2021
Merged
*: show an unsynced message for workers which didn't get any shard DDL (#1638) #1650
ti-chi-bot
merged 7 commits into
pingcap:release-2.0
from
ti-chi-bot:cherry-pick-1638-to-release-2.0
May 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
size/L
type/cherry-pick-for-release-2.0
labels
May 6, 2021
lance6716
reviewed
May 6, 2021
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
lance6716
added
require-LGT1
for small PR, LGT1 is enough
and removed
status/LGT1
One reviewer already commented LGTM
labels
May 6, 2021
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b91004c
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
require-LGT1
for small PR, LGT1 is enough
size/L
status/can-merge
status/LGT1
One reviewer already commented LGTM
type/cherry-pick-for-release-2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1638
What problem does this PR solve?
some users don't use
show-ddl-locks
to get unsynced tables, they usequery-status
instead, so we also show reasonable message inquery-status
What is changed and how it works?
Check List
Tests
Code changes
Related changes