Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-master: check etcd wal dir when restart #1672

Merged
merged 7 commits into from
May 12, 2021
Merged

dm-master: check etcd wal dir when restart #1672

merged 7 commits into from
May 12, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented May 11, 2021

What problem does this PR solve?

close #1671

What is changed and how it works?

check wal dir exist

Check List

Tests

  • Unit test

@ti-chi-bot ti-chi-bot requested a review from lichunzhu May 11, 2021 06:31
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 11, 2021
@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels May 11, 2021
@lance6716 lance6716 added this to the v2.0.4 milestone May 11, 2021
lichunzhu
lichunzhu reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help refine the join logic? Rest LGTM

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented May 11, 2021

need fix ut and add new logic, WIP

@GMHDBJD GMHDBJD added the status/WIP This PR is still work in progress label May 11, 2021
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels May 12, 2021
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels May 12, 2021
@ti-chi-bot ti-chi-bot added size/M and removed size/L labels May 12, 2021
@GMHDBJD GMHDBJD removed the status/WIP This PR is still work in progress label May 12, 2021
GMHDBJD
GMHDBJD commented May 12, 2021
View reviewed changes
.github/workflows/check-and-build.yml
@@ -82,5 +82,5 @@ jobs:
- name: GolangCI Lint
uses: golangci/golangci-lint-action@v2
with:
version: latest
version: v1.39
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use latest after we upgrade to go1.16, otherwise local build with go1.13 will fail

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented May 12, 2021

@csuzhangxc PTAL. Don't know whether fix the issue.

csuzhangxc
csuzhangxc approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • csuzhangxc
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 12, 2021
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented May 12, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 159bed2

@ti-chi-bot ti-chi-bot merged commit b0c72c9 into pingcap:master May 12, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dm that referenced this pull request May 12, 2021
@GMHDBJD @ti-chi-bot
dm-master: check etcd wal dir when restart (pingcap#1672)
ad37611
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1680.

@csuzhangxc csuzhangxc mentioned this pull request May 18, 2021
Merged
10 tasks
ti-chi-bot added a commit that referenced this pull request May 18, 2021
@ti-chi-bot
dm-master: check etcd wal dir when restart (#1672) (#1680)
2a52bfb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/M status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.4
Development

Successfully merging this pull request may close these issues.

dm-master may restarted fail
5 participants
@GMHDBJD @ti-chi-bot @lance6716 @csuzhangxc @lichunzhu