Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: refine action trigger #1679

Merged
merged 7 commits into from
May 20, 2021
Merged

test: refine action trigger #1679

merged 7 commits into from
May 20, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented May 12, 2021

What problem does this PR solve?

refine action trigger to speed up github action

What is changed and how it works?

  • binlog-9999/upstream-switch/arm build workflow will not trigger by PR
  • tmate session reduce to 30 minutes

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels May 12, 2021
lance6716
lance6716 reviewed May 12, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should add v2.0.3 in previous_v2

.github/workflows/upgrade-via-tiup.yml
@@ -82,7 +82,7 @@ jobs:
path: go/src/github.com/pingcap/dm

- name: Build
if: ${{ github.ref != 'refs/heads/main' }}
if: ${{ github.ref != 'refs/heads/master' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally, because DM uses master not main as branch name, all these steps will not be filterd. 🤔 Do you want to skip this action?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. If it's master branch, we use nightly version, don't need to build local version

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 12, 2021
@Ehco1996
Copy link
Contributor

/run-compatibility-test

@lance6716
Copy link
Collaborator

@Ehco1996 ptal

@lance6716 lance6716 mentioned this pull request May 19, 2021
Merged
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented May 20, 2021

/run-all-tests

ti-chi-bot pushed a commit to ti-community-infra/configs that referenced this pull request May 20, 2021
@lance6716
config: remove some slow check from "Required" (#317)
6df76a3 
fit pingcap/dm#1679
lichunzhu
lichunzhu reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 20, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d89e9b1

@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-compatibility-test

@ti-chi-bot ti-chi-bot merged commit 9c7b972 into pingcap:master May 20, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request May 20, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1712.

ti-chi-bot added a commit that referenced this pull request May 20, 2021
@ti-chi-bot
test: refine action trigger (#1679) (#1712)
7bc755c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@lance6716 lance6716 lance6716 approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 size/S status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GMHDBJD @Ehco1996 @lance6716 @ti-chi-bot @lichunzhu