syncer: update dependency to avoid exit when meet unsupported binlog (#1707) #1734
Conversation
Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
ti-chi-bot
added
needs-update-release-note
|
recorded in #1616 /run-all-tests |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
| @@ -1321,6 +1321,7 @@ func (s *Syncer) Run(ctx context.Context) (err error) { | |||
| } | |||
|
|
|||
| if err != nil { | |||
| // TODO: wrap the error with terror, and attach binlog position | |||
There was a problem hiding this comment.
is still need this commnet?
There was a problem hiding this comment.
this line should be deleted 😂 We should delete it in master branch and cherry pick here (could be another PR, or left for any future PR by the way)
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b636f87
|
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
This is an automated cherry-pick of #1707
What problem does this PR solve?
close #1682
What is changed and how it works?
add workaround for the error caused by go-mysql
Check List
Tests
Related changes