-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: add metric replicationLagGauge back (#1709) #1759
syncer: add metric replicationLagGauge back (#1709) #1759
Conversation
@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 401d12d
|
This is an automated cherry-pick of #1709
What problem does this PR solve?
in #1451
replicationLagGauge
What is changed and how it works?
use DM current ts minus binlog header ts to get the replication lag
Check List
Tests
dm_syncer_replication_lag
back againCode changes
GetServerUnixTS
Side effects
Related changes