Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: add metric replicationLagGauge back (#1709) #1759

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1709

What problem does this PR solve?

in #1451

  • Part 1 fix replicationLagGauge

What is changed and how it works?

use DM current ts minus binlog header ts to get the replication lag

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
    1. start any incremental task in any dm-worker
    2. check the workers metrics , you can find the dm_syncer_replication_lag back again

Code changes

  • Has exported function/method change
  • Add GetServerUnixTS

Side effects

  • Possible performance regression
  1. need get the time offset between DM and upstream db in background task Regularly

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added size/XXL status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 9, 2021
@ti-chi-bot
Copy link
Member Author

@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 10, 2021
@Ehco1996 Ehco1996 linked an issue Jun 10, 2021 that may be closed by this pull request
7 tasks
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 10, 2021
@Ehco1996
Copy link
Contributor

/run-unit-test

@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 401d12d

@ti-chi-bot ti-chi-bot merged commit dcc6842 into pingcap:release-2.0 Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve metrics to help better debug
4 participants