Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: adjust safemode duration to 2 * checkpointFlushInterval (#1777) #1779

Merged
merged 5 commits into from
Jun 18, 2021
Merged

syncer: adjust safemode duration to 2 * checkpointFlushInterval (#1777) #1779

merged 5 commits into from
Jun 18, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1777

What problem does this PR solve?

related to #1757

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/S type/cherry-pick-for-release-2.0 labels Jun 16, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 16, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 16, 2021
@ti-chi-bot
Copy link
Member Author

@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label Jun 17, 2021
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 4a452e5

@lance6716
Copy link
Collaborator

/run-all-tests

3 similar comments
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented Jun 18, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 066bd83 into pingcap:release-2.0 Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@glorv glorv glorv approved these changes

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees

@lance6716 lance6716

Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/S status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lance6716 @glorv @Ehco1996