Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

schemaTracker: fix operate-schema --flush panic #1799

Merged
merged 14 commits into from
Jul 2, 2021
Merged

schemaTracker: fix operate-schema --flush panic #1799

merged 14 commits into from
Jul 2, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 22, 2021

What problem does this PR solve?

close #1724 #1730

Tests

  • Unit test
  • Integration test

@GMHDBJD GMHDBJD added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 22, 2021
@lance6716
Copy link
Collaborator 

[2021-06-22T07:09:57.252Z] command: operate-schema get -s mysql-replica-01,mysql-replica-02 sequence_sharding_optimistic -d sharding_seq_opt -t t2 "result": true count: 0 != expected: 3

[2021-06-22T07:09:57.252Z] fail to run: [operate-schema get -s mysql-replica-01,mysql-replica-02 sequence_sharding_optimistic -d sharding_seq_opt -t t2]

[2021-06-22T07:09:57.252Z] Error: --flush flag is only used to set schema

@lance6716 lance6716 added this to the v2.0.5 milestone Jun 22, 2021
lance6716
lance6716 reviewed Jun 23, 2021
View reviewed changes
syncer/checkpoint.go Outdated Show resolved Hide resolved
tests/downstream_more_column/conf/diff_config.toml Outdated Show resolved Hide resolved
tests/downstream_more_column/run.sh Outdated Show resolved Hide resolved
tests/downstream_more_column/run.sh Show resolved Hide resolved
@purelind
Copy link

/run-unit-test

lance6716
lance6716 reviewed Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@purelind
Copy link

/run-unit-test

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jun 24, 2021
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 2, 2021

cc @Ehco1996

@GMHDBJD GMHDBJD added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Jul 2, 2021
@Ehco1996
Copy link
Contributor

Ehco1996 commented Jul 2, 2021

LGTM

@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label Jul 2, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ec2b9e9

@ti-chi-bot ti-chi-bot merged commit 6aa9642 into pingcap:master Jul 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 2, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1829.

ti-chi-bot added a commit that referenced this pull request Jul 2, 2021
@ti-chi-bot
schemaTracker: fix operate-schema --flush panic (#1799) (#1829)
d07916a
@lance6716 lance6716 mentioned this pull request Jul 7, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ehco1996 Ehco1996 Ehco1996 left review comments

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/L status/can-merge status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Milestone
v2.0.5
Development

Successfully merging this pull request may close these issues.

operate-schema set will use --flush as default action
5 participants
@GMHDBJD @lance6716 @purelind @ti-chi-bot @Ehco1996