Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: try check every returned err are handled #1817

Merged
merged 13 commits into from
Jul 6, 2021
Merged

*: try check every returned err are handled #1817

merged 13 commits into from
Jul 6, 2021

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Jun 25, 2021 •
edited
Loading

What problem does this PR solve?

close #1815

part of #1803

What is changed and how it works?

  1. precheck backoff-max in source config
  2. precheck do-tables, chunk-filesize in task config. (we will check all fields in another PR)
  3. check an error in pkg/ha/relay.go
  4. dump unit's panic issue

Check List

Tests

  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added size/XL and removed size/L labels Jun 25, 2021
@lance6716 lance6716 changed the title [WIP] *: try check every returned err are handled *: try check every returned err are handled Jun 25, 2021
@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 25, 2021
@lance6716 lance6716 added this to the v2.0.5 milestone Jun 25, 2021
@lance6716
Copy link
Collaborator Author

/run-all-tests

@lance6716
Copy link
Collaborator Author

/run-all-tests

GMHDBJD
GMHDBJD approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will the new linter be integrated?

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 2, 2021
@lance6716
Copy link
Collaborator Author

Will the new linter be integrated?

the new linter has many bad cases 😂 need more development

3pointer
3pointer approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 6, 2021
@lance6716
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 96683ac

@ti-chi-bot ti-chi-bot merged commit 9a1d433 into pingcap:master Jul 6, 2021
ti-chi-bot pushed a commit to ti-chi-bot/dm that referenced this pull request Jul 6, 2021
@lance6716 @ti-chi-bot
*: try check every returned err are handled (pingcap#1817)
695a021
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1842.

ti-chi-bot added a commit that referenced this pull request Jul 7, 2021
@ti-chi-bot
*: try check every returned err are handled (#1817) (#1842)
b1acf99
@GMHDBJD GMHDBJD mentioned this pull request Jul 23, 2021
Closed
@lance6716 lance6716 mentioned this pull request Jul 27, 2021
Merged
7 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 28, 2021
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@3pointer 3pointer 3pointer approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.0.5
Development

Successfully merging this pull request may close these issues.

setting checker.backoff-max to less than 1s will break operate-source without showing exact message
4 participants
@lance6716 @ti-chi-bot @3pointer @GMHDBJD