-
Notifications
You must be signed in to change notification settings - Fork 188
syncer: optimize safemode mechanism to improve performance (#1906) #1920
syncer: optimize safemode mechanism to improve performance (#1906) #1920
Conversation
/run-all-tests |
/merge |
@glorv: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 688b0e6
|
This is an automated cherry-pick of #1906
What problem does this PR solve?
Implement #1757 method a.
What is changed and how it works?
Reuse
exit_safe_binlog_name
,exit_safe_binlog_pos
,exit_safe_binlog_gtid
in checkpoint.exit_safe_binlog
, flushexit_safe_binlog
asap to avoid duplicate in the future.syncer
fails due to errors except execution errors or meet some errors when executing, don't update global checkpoint but update safe point to downstream. In other situations, update both global checkpoint and safe point.syncDML
andsyncDDL
's context tocontext.Background()
to make sure ddl/dmls can be replicated to downstream as much as possible event when context is canceled.Check List
Tests
Code changes
Side effects
Related changes