-
Notifications
You must be signed in to change notification settings - Fork 188
optimistic: fix optimist panic after table/source removed #1971
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
84738ed
to
eafbfcb
Compare
/run-all-tests |
/run-all-tests |
} | ||
// filter info which doesn't have SourceTable | ||
// SourceTable will be changed after user update block-allow-list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as opposed to cleaning up error etcd data here
maybe we can celar outated info in etcd after user update block-allow-list
is a better idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not reliable in current design.
user do a ddl,
stop-task
drop table
redo task(start-task remove meta)
the ddl info still in etcd, but sourceTable was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we clear data when remove-meta
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a idea
/merge |
This pull request has been accepted and is ready to merge. Commit hash: eafbfcb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
In response to a cherrypick label: new pull request created: #1984. |
What problem does this PR solve?
close #1970
What is changed and how it works?
Check List
Tests