Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

openapi: add source releated API #2055

Merged
merged 20 commits into from
Sep 1, 2021
Merged

openapi: add source releated API #2055

merged 20 commits into from
Sep 1, 2021

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

#1982

Part3 - Source Related APIs

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has interface methods change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Ehco1996
Ehco1996 commented Aug 27, 2021
View reviewed changes
dm/master/openapi.go Show resolved Hide resolved
dm/master/openapi_test.go Outdated Show resolved Hide resolved
dm/master/openapi_test.go Outdated Show resolved Hide resolved
dm/master/openapi_test.go Outdated Show resolved Hide resolved
@Ehco1996 Ehco1996 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Aug 27, 2021
@Ehco1996
Copy link
Contributor Author

/run-unit-test

@Ehco1996 Ehco1996 marked this pull request as ready for review August 27, 2021 07:13
Ehco1996
Ehco1996 commented Aug 30, 2021
View reviewed changes
dm/master/openapi.go Outdated Show resolved Hide resolved
Ehco1996
Ehco1996 commented Aug 30, 2021
View reviewed changes
dm/master/openapi_test.go Outdated Show resolved Hide resolved
tests/openapi/client/source.py Outdated Show resolved Hide resolved
tests/openapi/conf/dm-master1.toml Outdated Show resolved Hide resolved
lance6716
lance6716 reviewed Aug 30, 2021
View reviewed changes
dm/config/source_config_test.go Outdated Show resolved Hide resolved
dm/config/source_config_test.go Show resolved Hide resolved
dm/master/openapi.go Show resolved Hide resolved
dm/config/source_config.go Show resolved Hide resolved
@Ehco1996 Ehco1996 added this to the v2.1.0 milestone Aug 31, 2021
@lance6716 lance6716 added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Aug 31, 2021
lance6716
lance6716 reviewed Aug 31, 2021
View reviewed changes
dm/master/openapi.go Outdated Show resolved Hide resolved
dm/master/openapi.go Show resolved Hide resolved
dm/master/openapi.go Outdated Show resolved Hide resolved
dm/master/openapi.go Outdated Show resolved Hide resolved
dm/master/openapi.go Show resolved Hide resolved
tests/openapi/run.sh Outdated Show resolved Hide resolved
lance6716
lance6716 reviewed Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

dm/master/openapi.go Outdated Show resolved Hide resolved
dm/master/openapi.go Show resolved Hide resolved
dm/master/openapi.go Outdated Show resolved Hide resolved
tests/openapi/run.sh Outdated Show resolved Hide resolved
tests/openapi/run.sh Outdated Show resolved Hide resolved
lance6716
lance6716 reviewed Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

openapi/spec/dm.yaml Outdated Show resolved Hide resolved
tests/openapi/run.sh Show resolved Hide resolved
dm/master/openapi.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Sep 1, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 1, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Sep 1, 2021

/run-unit-test

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ddc3a7

@ti-chi-bot ti-chi-bot merged commit 0e1b62f into pingcap:master Sep 1, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2081.

ti-chi-bot added a commit that referenced this pull request Sep 2, 2021
@ti-chi-bot
openapi: add source releated API (#2055) (#2081)
495b796
@Ehco1996 Ehco1996 mentioned this pull request Oct 25, 2021
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 25, 2021
Merged
@lance6716 lance6716 mentioned this pull request Apr 28, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sleepymole sleepymole sleepymole left review comments

@sunzhaoyang sunzhaoyang sunzhaoyang left review comments

@glorv glorv glorv approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Ehco1996 @ti-chi-bot @lance6716 @sunzhaoyang @glorv @sleepymole